4 comments:
Patch Set #37, Line 11: flexibility
I don't see that achieved. As the sequence is hardcoded and no functions are optional there's no flexibility.
Patch Set #37, Line 49: custom
That reads as everything introduced is optional, and SoC maintainers can do whatever they want.
File src/soc/intel/common/basecode/bootblock/bootblock.c:
Patch Set #37, Line 39: bootblock_soc_early_init(void)
This reminds me on UEFI implementations that use function pointers everywhere
Patch Set #37, Line 102: (CONFIG(PAGING_IN_CACHE_AS_RAM))
Why is there APL/GLK specific code here? Wasn't the idea to make it more flexible?
To view, visit change 18457. To unsubscribe, or for help writing mail filters, visit settings.