Apart from the comment on patchset 4 on the enable function override for the GPIO LDNs this looks good to me. If you're not sure what I meant there, just say so and I'll try to explain it better :)
I'm not sure if this might cause some issues, but you mentioned in the patch that changing the bits in register 0x30 of the GPIO LDNs might interfere with the embedded microcontroller in the SIO.

Patch set 6:Code-Review +1

View Change

To view, visit change 34948. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78eca4ba2948c36a386306887f62773580f6e444
Gerrit-Change-Number: 34948
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 05 Sep 2019 20:32:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment