Patch set 3:Code-Review +1

View Change

4 comments:

• File src/soc/intel/xeon_sp/include/soc/pmc.h:

  • Patch Set #3, Line 28:

    nit: two spaces here (it's a bit inside a register)

• File src/soc/intel/xeon_sp/pmutil.c:

  • Patch Set #3, Line 14: int

    bool

  • Patch Set #3, Line 16: RTC_BATTERY_DEAD

    Instead of masking here, I'd read the register as-is inside a variable and mask the desired bit elsewhere. This should make the lines fit within 96 characters.

  • Patch Set #3, Line 16: PCH_DEVFN_PMC<<12

    huh? Why this shift?

To view, visit change 43004. To unsubscribe, or for help writing mail filters, visit settings.