Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31489 )
Change subject: [WIP] soc/amd/common: Use static allocation for params ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/31489/5/src/soc/amd/common/block/pi/agesawra... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/31489/5/src/soc/amd/common/block/pi/agesawra... PS5, Line 425: : : : : : : : This section of code is needed, otherwise aip->AllocationMethod will always be ByHost and cause confusion inside AGESA (will assume heap is always ByHost) However, AGESA internals are different depending on ByHost, PreMemHeap and PostMemDram. I believe that it'll not boot without this code.
https://review.coreboot.org/#/c/31489/5/src/soc/amd/common/block/pi/agesawra... PS5, Line 430: static union AMD_MAX_ALLOC_PARAMS sp; I'm ok with making this static, but only p2, p11 and p12 are needed.