Subrata Banik submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Maulik V Vaghela: Looks good to me, approved Angel Pons: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
vendorcode/intel/fsp/alderlake: Fix FSPS_ARCH_UPD redefinition issue

FSPS_ARCH_UPD struct is part of edk2-stable202005 branch (FspApi.h)
hence local definition of FSPS_ARCH_UPD inside FspsUpd.h is causing
compilation issue.

Change-Id: Id5b3637d9ab6d87aab6da810f9c83d3258900a29
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45191
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Maulik V Vaghela <maulik.v.vaghela@intel.com>
---
M src/vendorcode/intel/fsp/fsp2_0/alderlake/FspsUpd.h
1 file changed, 0 insertions(+), 30 deletions(-)

diff --git a/src/vendorcode/intel/fsp/fsp2_0/alderlake/FspsUpd.h b/src/vendorcode/intel/fsp/fsp2_0/alderlake/FspsUpd.h
index 39c360d..7ec577a 100644
--- a/src/vendorcode/intel/fsp/fsp2_0/alderlake/FspsUpd.h
+++ b/src/vendorcode/intel/fsp/fsp2_0/alderlake/FspsUpd.h
@@ -80,36 +80,6 @@

#define SI_PCH_MAX_DEVICE_INTERRUPT_CONFIG 64 ///< Number of all PCH devices

-
-/** FSPS_ARCH_UPD
-**/
-typedef struct {
-
-/** Offset 0x0020 - Reserved
-**/
- UINT8 Revision;
-
-/** Offset 0x0021 - Reserved
-**/
- UINT8 Reserved[3];
-
-/** Offset 0x0024 - Reserved
-**/
- UINT32 Length;
-
-/** Offset 0x0028 - Reserved
-**/
- UINT32 FspEventHandler;
-
-/** Offset 0x002C - Reserved
-**/
- UINT8 EnableMultiPhaseSiliconInit;
-
-/** Offset 0x002D - Reserved
-**/
- UINT8 Reserved1[19];
-} FSPS_ARCH_UPD;
-
/** Fsp S Configuration
**/
typedef struct {

To view, visit change 45191. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5b3637d9ab6d87aab6da810f9c83d3258900a29
Gerrit-Change-Number: 45191
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged