Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41869 )
Change subject: amd/microcode: Change equivalant ID width as 16bit ......................................................................
Patch Set 2:
Patch Set 2:
I've only looked at the internal fam17h RV1/PCO PPR, but that one disagrees with this. was there a change between fam16h and fam17h?
struct microcode { uint32_t date_code; uint32_t patch_id;
uint16_t mc_patch_data_id; uint8_t reserved1[6];
uint32_t chipset1_dev_id; uint32_t chipset2_dev_id;
uint16_t processor_rev_id; //This field is 16bit.
uint8_t chipset1_rev_id; uint8_t chipset2_rev_id;
uint8_t reserved2[4];
uint8_t m_patch_data[F17H_MPB_MAX_SIZE-F17H_MPB_DATA_OFFSET];
};