Attention is currently required from: Christian Walter, Julius Werner, Yu-Ping Wu.
View Change
1 comment:
Patchset:
Patch Set #2:
> Loading a payload should probably not take over two seconds, unless it is ridiculously huge... […]
With a bit of digging it turned out that on Elkhart Lake FSPS somehow disables BIOS flash caching (coreboot adds the MTRR quite early in bootblock and it remains set up until a late FSPS-call, then it is overwritten by something different with no more spare MTRRs to add the BIOS-range back in). I have no clue why and where exactly but this explains pretty much the long time I face when the payload is loaded.
I gave this patch a try on Apollo Lake (mc_apl6) and it looks good there. So I guess this patch is fine and I need to find the caching issue on Elkhart Lake.
To view, visit change 59682. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cec0ca2d9d311626a087318d1d78163243bfc3c
Gerrit-Change-Number: 59682
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Jakub Czapiga <jacz@semihalf.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Attention: Christian Walter <christian.walter@9elements.com>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso@google.com>
Gerrit-Comment-Date: Thu, 02 Dec 2021 11:13:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Comment-In-Reply-To: Werner Zeh <werner.zeh@siemens.com>
Gerrit-MessageType: comment