This patch leads to a compile failure with glibc-headers-2.12-1.212 (currently installed on one of my systems) due to old endian.h in this package.

Is it missing le32toh()? I intentionally tried to standardize on something that I thought would be more widely available with this new commonlib/bsd code (as opposed to things like le32_to_cpu() which we also have in coreboot but I think are less widespread).

AFAIK there's no fully official POSIX API for little-endian stuff (only ntohl() for big-endian), so I think this is the next best thing we can try to rely on. Is this a big problem or are you okay with just requiring the newer version?

View Change

To view, visit change 38420. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I316cea70930f131e8e93d4218542ddb5ae4b63a2
Gerrit-Change-Number: 38420
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Philipp Hug <philipp@hug.cx>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: 9elements QA <hardwaretestrobot@gmail.com>
Gerrit-CC: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Comment-Date: Tue, 28 Jan 2020 21:36:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment