3 comments:
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
Patch Set #4, Line 242: register "probed" = "1"
Why is probed required here?
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
/* PCH_I2C_AUDIO_SDA */
PAD_CFG_NF(GPP_H8, NONE, DEEP, NF1),
/* PCH_I2C_AUDIO_SCL */
PAD_CFG_NF(GPP_H9, NONE, DEEP, NF1),
Can we please place these along with rest of the GPP_H?
PAD_CFG_GPI_APIC(GPP_H0, NONE, PLTRST, LEVEL, NONE),
/* SPEAKER SD MODE ENABLE */
PAD_CFG_GPO(GPP_H3, 0, DEEP),
/* DMIC_CLK_0_SNDW4_CLK */
PAD_CFG_NF(GPP_D19, NONE, DEEP, NF1),
/* DMIC_DATA_0_SNDW4_DATA */
PAD_CFG_NF(GPP_D20, NONE, DEEP, NF1),
/* SPP_MCLK */
PAD_CFG_NF(GPP_D23, NONE, DEEP, NF1),
Can we please order these according to GPP groups?
To view, visit change 31280. To unsubscribe, or for help writing mail filters, visit settings.