Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50954 )
Change subject: soc/intel/skylake: Move `gspi_early_bar_init()` call ......................................................................
soc/intel/skylake: Move `gspi_early_bar_init()` call
For consistency with newer platforms, do this in pch.c instead.
Change-Id: Ie7a1d3e106553388df55044be91c7837061c42da Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/50954 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/soc/intel/skylake/bootblock/bootblock.c M src/soc/intel/skylake/bootblock/pch.c 2 files changed, 3 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/soc/intel/skylake/bootblock/bootblock.c b/src/soc/intel/skylake/bootblock/bootblock.c index 7b8b147..276bb48 100644 --- a/src/soc/intel/skylake/bootblock/bootblock.c +++ b/src/soc/intel/skylake/bootblock/bootblock.c @@ -2,7 +2,6 @@
#include <bootblock_common.h> #include <intelblocks/fast_spi.h> -#include <intelblocks/gspi.h> #include <intelblocks/systemagent.h> #include <intelblocks/tco.h> #include <intelblocks/uart.h> @@ -34,7 +33,6 @@ */ report_platform_info(); bootblock_pch_init(); - gspi_early_bar_init();
/* Program TCO_BASE_ADDRESS and TCO Timer Halt */ tco_configure(); diff --git a/src/soc/intel/skylake/bootblock/pch.c b/src/soc/intel/skylake/bootblock/pch.c index b15bf98..1685e43 100644 --- a/src/soc/intel/skylake/bootblock/pch.c +++ b/src/soc/intel/skylake/bootblock/pch.c @@ -5,6 +5,7 @@ #include <intelblocks/cse.h> #include <intelblocks/dmi.h> #include <intelblocks/fast_spi.h> +#include <intelblocks/gspi.h> #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> #include <intelblocks/p2sb.h> @@ -142,4 +143,6 @@
/* initialize Heci interface */ heci_init(HECI1_BASE_ADDRESS); + + gspi_early_bar_init(); }