View Change
1 comment:
Commit Message:
Patch Set #9, Line 15: needs to be heuristic
It can also be desirable to return an error code sooner and handle the failure quickly, assuming it' […]
In the Tioga Pass case, is it that MP init takes longer than one second, or does some core get stalled? If it's just that waking so many cores takes more time, then it's not a big deal. We shouldn't be hitting the timeout in regular cases anyway.
To view, visit change 38546. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc079fc6aa8641d4ac8d8e726899b6c8d055052e
Gerrit-Change-Number: 38546
Gerrit-PatchSet: 10
Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Andrey Petrov <anpetrov@fb.com>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 31 Jan 2020 10:42:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang <jonzhang@fb.com>
Comment-In-Reply-To: David Hendricks <david.hendricks@gmail.com>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment