Patch Set 1:

While it is sort of remainer from the days before variable
acpi_slp_type was declared static (and someone evaluated the global
variable directly), the call still serves a purpose; it prints into
console exactly once, early in ramstage, if we are on normal or S3
boot path.

without calling this function also i'm seeing normal vs s3 resume print in early ramstage code.

My point was the message currently appears at a consistent and convenient location regardless of platform code.

View Change

To view, visit change 31140. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc57804074a58315e72e276fcae799febc10612d
Gerrit-Change-Number: 31140
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 05 Feb 2019 17:58:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment