Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33033 )
Change subject: superio/common: Add ssdtgen for generic SuperIOs
......................................................................
Patch Set 25:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33033/25/src/superio/common/generic...
File src/superio/common/generic.c:
https://review.coreboot.org/c/coreboot/+/33033/25/src/superio/common/generic...
PS25, Line 100: FIELDLIST_NAMESTR("IOAL", 8),
It's usually called IOA*
I thought those were the names used for IO0H/IO0L. Aren't those 0-indexed? I'd expect to have IO[0123][HL] (4 IO resources; not sure if 3 or 4 was the maximum I've seen in real devices that are from this century) here and since the first ones seem to have another name used (is that by spec or by convention? I'd guess the latter), I'd still expect the IO[123][HL] fields in addition to the IOA[HL] fields
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33033
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2716ae0580d68e5d4fcc484cb1648a2cdc1f4ca0
Gerrit-Change-Number: 33033
Gerrit-PatchSet: 25
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 26 Aug 2019 20:19:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment