[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/brya/var/trulo: Update PL1 values as per silicon TDP

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, V Sowmya, Vidya Gopalakrishnan, Vinay Kumar.

Subrata Banik has posted comments on this change by Vidya Gopalakrishnan. ( https://review.coreboot.org/c/coreboot/+/85184?usp=email )

Change subject: mb/google/brya/var/trulo: Update PL1 values as per silicon TDP
......................................................................

Patch Set 4:

(1 comment)

File src/mainboard/google/brya/variants/trulo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/85184/comment/72c452d6_0c997eaa?usp... :
PS4, Line 184: 	register "power_limits_config[ADL_N_041_6W_CORE]" = "{
             : 		.tdp_pl1_override = 20,
             : 		.tdp_pl2_override = 25,
             : 		.tdp_pl4 = 78,
             : 	}"
             : 
             : 	register "power_limits_config[ADL_N_081_7W_CORE]" = "{
             : 		.tdp_pl1_override = 20,
             : 		.tdp_pl2_override = 25,
             : 		.tdp_pl4 = 78,
             : 	}"
             : 
             : 	register "power_limits_config[ADL_N_081_15W_CORE]" = "{
             : 		.tdp_pl1_override = 20,
             : 		.tdp_pl2_override = 35,
             : 		.tdp_pl4 = 83,
             : 	}"
wondering if your goal is to block PLx overrides which I felt is something that many ODMs are using at present.

you are updating the defined power limits which is okay but why you would like to avoid any hooks to perform Plx override ?