View Change

6 comments:

• File src/ec/google/chromeec/compile_time_macros.h:

  • Patch Set #2, Line 36: ## line

    why not __COUNTER__? https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html

  • Patch Set #2, Line 39: BUILD_ASSERT

    or _Static_assert (https://en.wikichip.org/wiki/c/static_assertion)

  • Patch Set #2, Line 42: run time

    How is run time behavior affected by -Werror=div-by-zero?

  • Patch Set #2, Line 48: ARRAY_SIZE

    already defined in src/commonlib/include/commonlib/helpers.h

  • Patch Set #2, Line 57: offsetof

    again, we already have a copy in helpers.h

  • Patch Set #2, Line 61: member_size

    and again.

To view, visit change 31885. To unsubscribe, or for help writing mail filters, visit settings.