1 comment:
File src/soc/amd/common/block/smbus/smbus.c:
Patch Set #2, Line 23: return controller->reg8[reg];
What's the reasoning for not using read8()? pointer aliasing rules?
Aliasing rules hit on every writeX() but for symmetry I avoid readX() here. Sequences where one does multiple MMIO writes with small offsets from same base produce a lot prettier code without writeX().
To view, visit change 42074. To unsubscribe, or for help writing mail filters, visit settings.