Patch Set 4:

Patch Set 4: Code-Review-1

The functionality of sending host firmware version and date to OpenBMC is not supermicro specific, it is also needed on other servers, such as OCP Delta Lake server. Because the IPMI command is OEM specific, so the LUN#, cmd/rsp format could be different between supermicro server and OCP servers. This patch as-is is good, but I suppose we could do even better. Let's find a design to support both.

Tim, could you reply back with OCP Delta Lake IPMI OEM command details for sending host firmware version and date? Also test the (revised) patch on Delta Lake? Note that in our case, BIOS version is set through [CB:42029].

Tim, please also check the comments for [CB:41605].

I think this patch can do like I've done in [CB:41605 and CB:42242]. Not put supermicro specific function with common function together but divide them into two parts.

Jonathan, you mean adding new function to send host firmware version and date in deltalake?

I take my comment back. For OCP server OSF design, one principal is to make coreboot as slim as possible, any functionality that can be done in Linuxboot is supported in Linuxboot. This includes the IPMI command to send FW version and build date to BMC.

Patch set 4:Code-Review +1

View Change

To view, visit change 38002. To unsubscribe, or for help writing mail filters, visit settings.