Repost as gerrit messed up the message:

There's one file making use of struct smbios_entry: src/arch/x86/smbios.c
Of course you would add a second struct for the 64bit entry point and keep the 32bit one.

If the callers should provide the value in the correct unit the SMBIOS spec defines, you should update all callers instead.

I don't see how chromium patches relate to coreboot and why you would mention them in the commit message.

View Change

To view, visit change 32090. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1171c20ac85a2231d949d4ac1c3e3c544ba3e5ef
Gerrit-Change-Number: 32090
Gerrit-PatchSet: 5
Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso@intel.com>
Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso@intel.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Francois Toguo Fotso <francois.toguo.fotso@intel.corp-partner.google.com>
Gerrit-CC: Lijian Zhao <lijian.zhao@intel.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Comment-Date: Fri, 29 Mar 2019 17:23:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment