Attention is currently required from: Julius Werner.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68133 )
Change subject: util/chromeos/gen_test_hwid.sh: Replace usage of hexdump
......................................................................
Patch Set 1:
(1 comment)
File util/chromeos/gen_test_hwid.sh:
https://review.coreboot.org/c/coreboot/+/68133/comment/8e1fe3bb_4343ba90
PS1, Line 16: xargs
Not sure what the xargs is supposed to do here? Looks good otherwise.
So it occurs that `od` add a SPACE at the beginning of its output and LF at the end, thus the xargs (to remove SPACE) and tr (to remove LF)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icad93933335b8c5ebd8fee74cc9aaed36bb56482
Gerrit-Change-Number: 68133
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 07 Oct 2022 14:44:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment