3 comments:
Patch Set #1, Line 24: config HAVE_VBE_LINEAR_FRAMEBUFFER
A bit off-topic, but since I just looked through this again... what's the difference between HAVE_VBE_LINEAR_FRAMEBUFFER and HAVE_LINEAR_FRAMEBUFFER? As far as I can tell it doesn't seem to make any practical difference in behavior? Could we combine those two into one?
File src/drivers/aspeed/ast2050/Kconfig:
Patch Set #1, Line 10: select VBOOT_FORCE_DISPLAY_INIT if MAINBOARD_DO_NATIVE_VGA_INIT
Since we want to set the option when display init is just never enabled at all too, I think you don't need the 'if' here.
File src/mainboard/google/oak/Kconfig:
Patch Set #1, Line 49: select VBOOT_FORCE_DISPLAY_INIT
This seems wrong? Oak can skip display init (used to be selected from mt8173/Kconfig). […]
edit: Okay, I remember now that Oak's display init starts from the mainboard. So this is probably fine.
To view, visit change 34622. To unsubscribe, or for help writing mail filters, visit settings.