1 comment:
File src/security/intel/stm/StmPlatformSmm.c:
Patch Set #2, Line 165: * algorithm. (align on 4K)
Where is this documented? I skimmed through the STM manual and couldn't […]
My original (align on 4k) smm_save_state_size was based on the comments within Bios/StmCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c (in the STM github), lines 982-1048 and I settled on a 4K size because, in effect that was their granularity. Obviously, I see the error of my ways. So, I look at the problem in a different manner. I look at the structure layout.
SMRAM_SAVE_STATE_MAP 0xfc00-0xffff - 0x400
SMM_PSD_OFFSET 0xfb00-0xffff - 0x100
So, the state area needs now to be increased to 0x500.
There are no requirements as to alignment, just increase the state area by 0x100, which I'll modify when I get back to my development system.
This should make it easier.
Should we work to increment SMBASE in the positive direction? Or, does that break something important?
To view, visit change 38768. To unsubscribe, or for help writing mail filters, visit settings.