7 comments:
Not done?
Done
Please note the datasheet name und revision. […]
Done
Not done?
Done
File src/soc/mediatek/mt8192/i2c.c:
Patch Set #3, Line 145: static void mtk_i2c_speed_init(uint8_t bus)
Why can’t this be common code?
Different soc has some different register, such as: ltiming, so we need a place to initialize them separately.
Patch Set #3, Line 156: (400 * KHz * sample_div * 2) * clock_div);
Should fit into 96 characters.
The previous codes follow the 80 characters rule. Maybe we need a new patch to fix these code style problems.
Patch Set #3, Line 161: Timing
timing
Ack
Patch Set #3, Line 169: clock_div - 1);
Fits into one line.
The previous codes follow the 80 characters rule. Maybe we need a new patch to fix these code style problems.
To view, visit change 47800. To unsubscribe, or for help writing mail filters, visit settings.