Tim Wawrzynczak submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Sathyanarayana Nujella: Looks good to me, but someone else must approve Nick Vaccaro: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
mb/google/volteer/halvor: Update settings for audio function

Configure overridetree settings for audio function.

BUG=b:153680359, b:163382106
TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage

Signed-off-by: Frank Wu <frank_wu@compal.corp-partner.google.com>
Change-Id: I107f6fc21b99d80d69931139dc50e7d5873a8e52
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44409
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
---
M src/mainboard/google/volteer/variants/halvor/overridetree.cb
1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/src/mainboard/google/volteer/variants/halvor/overridetree.cb b/src/mainboard/google/volteer/variants/halvor/overridetree.cb
index e337a02..73767c6 100644
--- a/src/mainboard/google/volteer/variants/halvor/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/halvor/overridetree.cb
@@ -29,7 +29,9 @@
register "uid" = "0"
register "desc" = ""Right Speaker Amp""
register "name" = ""MAXR""
- device i2c 31 on end
+ device i2c 31 on
+ probe AUDIO MAX98373_ALC5682I_I2S_UP4
+ end
end
chip drivers/i2c/max98373
register "vmon_slot_no" = "2"
@@ -37,7 +39,9 @@
register "uid" = "1"
register "desc" = ""Left Speaker Amp""
register "name" = ""MAXL""
- device i2c 32 on end
+ device i2c 32 on
+ probe AUDIO MAX98373_ALC5682I_I2S_UP4
+ end
end
end # I2C #0 0xA0E8
device pci 15.1 on
@@ -113,13 +117,6 @@
device i2c 15 on end
end
end # I2C5 0xA0C6
- device pci 1f.3 on
- chip drivers/generic/max98357a
- register "hid" = ""MX98357A""
- register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_F18)"
- register "sdmode_delay" = "5"
- device generic 0 on end
- end
- end # Intel HD audio 0xA0C8-A0CF
+ device pci 1f.3 on end # Intel HD audio 0xA0C8-A0CF
end
end

To view, visit change 44409. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I107f6fc21b99d80d69931139dc50e7d5873a8e52
Gerrit-Change-Number: 44409
Gerrit-PatchSet: 8
Gerrit-Owner: Frank Wu <frank_wu@compal.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Kevin Cheng <kevin.cheng@intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg@chromium.org>
Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Alan Lee <alan_lee@compal.corp-partner.google.com>
Gerrit-CC: Amanda Hwang <amanda_hwang@compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged