5 comments:
File src/soc/amd/common/block/include/amdblocks/lpc.h:
Patch Set #2, Line 78: #define LPC_SELECT_SIO_4E4F 1
Add a comment explaining why these 2 defines are Boolean
I don't feel like a selection from among two addresses lends itself very well to the bool idea of true and false. I want the mb consumer of this only to consider using the right define, not get caught up in whether it's true or false.
true
Same as above.
false
Same as above.
File src/soc/amd/common/block/lpc/lpc_util.c:
Maybe for clarity, is_it_uart1
I don't think that adds much clarity, given what I have below. The bool already should enforce effectively only one of two choices.
Patch Set #2, Line 174: LPC_SELECT_SIO_2E2F
Making the input a bool, the check against a value is no longer needed and makes no sense. […]
I don't feel like a selection of addresses lends itself well to true/false.
To view, visit change 35271. To unsubscribe, or for help writing mail filters, visit settings.