Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49130 )
Change subject: [UNTESTED] sb/intel/bd82x6x: Correct xHCI sleep workaround
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49130/2/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/smihandler.c:
https://review.coreboot.org/c/coreboot/+/49130/2/src/southbridge/intel/bd82x...
PS2, Line 153: PCI_BASE_ADDRESS_0 + 4
nit: PCI_BASE_ADDRESS_1 or I wonder if a new macro, PCI_BASE_ADDRESS_0_UPPER or similar would be mor […]
I explicitly used the `+ 4` because I felt `PCI_BASE_ADDRESS_1` would look like it's a different BAR. I can use `PCI_BASE_ADDRESS_1` if it feels more correct, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49130
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabce6c52fac781dc694f5b589fab2e9fe438f3f5
Gerrit-Change-Number: 49130
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Jan 2021 19:43:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment