This change is ready for review.
7 comments:
Patch Set #2, Line 9: beind
behind
Ack
Patch Set #2, Line 29: AP does not wait (and firmware screen is displayed on HDMI monitor).
What monitors did you test with?
Ack
File src/mainboard/google/hatch/variants/puff/mainboard.c:
Patch Set #2, Line 33: gpio_input(gpio);
This would be unnecessary with the suggestion below.
Done
Patch Set #2, Line 42: mdelay(200);
200 ms seems too long for fast boot experience, doesn’t it? 10 ms or 20 ms?
Are you sure you understand the code?
Patch Set #2, Line 45: stopwatch_duration_msecs(&sw));
Should fit on one line.
Ack
Patch Set #2, Line 54: gpio_input(GPIO_HDMI_HPD);
gpio_input(GPIO_DP_HPD);
Done
&& !gpio_get(GPIO_DP_HPD)
Done
To view, visit change 38475. To unsubscribe, or for help writing mail filters, visit settings.