Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49058 )
Change subject: mb/google/hatch (baseboard): add ACPI backlight support
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49058/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/49058/2/src/mainboard/google/hatch/...
PS2, Line 32: select DRIVERS_GFX_GENERIC
I'm not sure if this driver is compatible with coreboot ACPI backlight support :/
looks like that's just to generate ACPI for a privacy screen/filter (e.g.) not the primary display output
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49058
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ce4c6e1c78299e89760a1356da452d56ba0aee6
Gerrit-Change-Number: 49058
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Jan 2021 01:14:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment