Attention is currently required from: Felix Singer, Benjamin Doron, Paul Menzel, Angel Pons.
View Change
1 comment:
Patchset:
Patch Set #174:
What should be done before this change can be committed? I can write documentation if I have to.
There are no formal requirements like presence of documentation. Generally,
the less you put into one commit the easier it is to get somebody to ack (+2)
it. So if you plan on writing documentation you should definitely put it into
a separate commit. Review doesn't scale linearly.
This commit is already pretty big as is. And it's not 100% tidy. For instance, what I spotted skimming through random files:
- The commit message says vboot is untested but there are a lot of vboot references in the code. If some advanced feature is untested, please (re)move it.
- There's explicit dead code, e.g. `#if 0`. Anything like that is a burden for the reviewer and future maintenance, it's unlikely to be acked.
- There are comments that disagree with the code. For instance in `gpio.c` a lot of `// NC` but the code configures a native function. The commit doesn't have to be perfect, but it needs to be consistent with itself.
- If you want you can keep unfinished things in separate commits on Gerrit for
- future reference.
I know you put a lot of work into this, and so did reviewers AFAICS. So we
definitely want to get it in! I suggest to trim it down a little to make it
easier to digest in one go. Anything that is untested/unfinished or otherwise
smells funny should be left for a later review.
To view, visit change 35523. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6340116abfeb2fbd280d143b74d323e4da3566f6
Gerrit-Change-Number: 35523
Gerrit-PatchSet: 174
Gerrit-Owner: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Sun, 11 Apr 2021 10:43:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-MessageType: comment