Attention is currently required from: Eran Mitrani, Jakub Czapiga, Jeremy Soller, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Subrata Banik, Tarun, Werner Zeh.
Hello Eran Mitrani, Jakub Czapiga, Jeremy Soller, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Subrata Banik, Tarun, Werner Zeh, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/77445?usp=email
to look at the new patch set (#11).
Change subject: intelblocks/acpi: Reserve SBREG BAR/PCH_PRESERVED resource properly ......................................................................
intelblocks/acpi: Reserve SBREG BAR/PCH_PRESERVED resource properly
Reserve SBREG BAR if it is outside of the PCH reserved memory range. Desktop series processors have larger SBREG BARs, which, unlike mobile processors, do not fall into the standard PCH reserved range (0xfc800000 - 0xfe7fffff). Special treatment is required if the GPIO ACPI device is exposed and the GPIO driver claims a part of the SBREG BAR (or PCH_PRESERVED range depending on SBREG BAR placement). In such a case the SBREG BAR or PCH_PRESERVED resource has to be fragmented into pieces, which are not claimed by the GPIO driver. coreboot always exposes the GPIO device (_STA is hardcoded to 0xF).
Add ACPI methods in SoC-specific gpio.asl files, which return the ResourceTemplate(s) of SBREG BAR or PCH_PRESERVED resource fragments not claimed by the GPIO device. Concatenate it with the other resources reported by MCHC device.
TEST=Boot Windows 11 on MSI PRO Z790-P and notice the yellow bang near GPIO device in Device Manager disappeared. When whole SBREG BAR was reserved, the error indicated that device could not find enough free resources. Also, the GPIO device must be placed under _SB scope for the yellow bang to disappear.
Change-Id: Ibaf45daba37e3acfcea0e653df69fa5c2f480c4a Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com --- M src/soc/intel/alderlake/acpi/gpio.asl M src/soc/intel/alderlake/include/soc/iomap.h M src/soc/intel/cannonlake/acpi/gpio.asl M src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl M src/soc/intel/common/block/acpi/acpi/northbridge.asl M src/soc/intel/elkhartlake/acpi/gpio.asl M src/soc/intel/jasperlake/acpi/gpio.asl M src/soc/intel/meteorlake/acpi/gpio.asl M src/soc/intel/meteorlake/include/soc/iomap.h M src/soc/intel/tigerlake/acpi/gpio.asl M src/soc/intel/tigerlake/acpi/gpio_pch_h.asl 11 files changed, 402 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/77445/11