View Change
5 comments:
File src/device/oprom/realmode/x86.c:
Patch Set #15, Line 357:
if (!vbe_mode_info_valid())
return;
This is redundant now. We know it is valid, because we just set it. In […]
Done
File src/drivers/intel/fsp1_1/fsp_gop.c:
Patch Set #15, Line 32: BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_EXIT, fill_framebuffer_info, NULL);
How about calling it from fsp_run_silicon_init() along with the […]
Done
File src/drivers/intel/fsp2_0/graphics.c:
Patch Set #15, Line 119: BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_EXIT, fill_framebuffer_info, NULL);
At end of fsp_silicon_init()?
Done
File src/drivers/intel/gma/hires_fb/gma-gfx_init.adb:
Patch Set #15, Line 35: end fb_add_framebuffer_info;
What's the purpose of this function? Can't we just call the C function […]
Done
Patch Set #15, Line 106: end if;
Would be nicer to have only one `if` and call the C function directly, e.g. […]
Done
To view, visit change 39003. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife507f7e7beaf59854e533551b4b87ea6980c1f4
Gerrit-Change-Number: 39003
Gerrit-PatchSet: 16
Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc@intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Huang Jin <huang.jin@intel.com>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy@intel.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki@intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn@eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 22 May 2020 14:53:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment