13 Nov
2018
13 Nov
'18
12:29 p.m.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/29434 )
Change subject: mb/lenovo/x220: Add x1 as a variant ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/29434/8/src/mainboard/lenovo/x220/variants/x... File src/mainboard/lenovo/x220/variants/x1/overridetree.cb:
https://review.coreboot.org/#/c/29434/8/src/mainboard/lenovo/x220/variants/x... PS8, Line 1: chip northbridge/intel/sandybridge
looks like this a normal devicetree, not an overridetree
There just are a lot of parameters needing to be override. You can compare this with the base tree src/mainboard/lenovo/x220/devicetree.cb, and you can see a lot of values are absent here.
--
To view, visit https://review.coreboot.org/29434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1
Gerrit-Change-Number: 29434
Gerrit-PatchSet: 8
Gerrit-Owner: Bill XIE persmule@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Bill XIE persmule@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 13 Nov 2018 12:29:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No