7 comments:
File src/soc/amd/picasso/Kconfig:
config ROMSTAGE_MAX_SIZE
hex "Size of first execution stage"
default 0x10000
help
The base address where romstage should be linked. This is the
uncompressed size of romstage.
This is the second instance of this entry. Maybe delete this or the one above. If you have it here just so it will be inside the PSP menu as well as outside, at least remove the default.
config PSP_WHITELIST_BL_FILE
string "Whitelist-capable bootloader file name"
depends on HAVE_PSP_WHITELIST_FILE
default "3rdparty/blobs/soc/amd/picasso/PSP/PspBootLoader_WL_RV.sbin"
Do we need this entry? Just update the standard bootloader file based on HAVE_PSP_WHITELIST_FILE?
At the very least, this and the below PSP_WHITELIST_FILE entries could be combined, assuming you'll have both in the same directory.
File src/soc/amd/picasso/Makefile.inc:
Maybe add the AMD document number for people with AMD NDA access?
# type = 0x3
PSPRCVR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspRecoveryBootLoader_prod_RV.sbin
Optional?
# type = 0x9
PSP_SEC_DBG_KEY_FILE=$(top)/$(FIRMWARE_LOCATE)/RavenSecureDebug_PublicKey.bin
Should this be optional like psp secure os?
Patch Set #4, Line 152: "0x0000000010000001"
Mark this as NDA description only? Otherwise I'm sure there will be questions about what each bit means.
Do we really want this hardcoded in the makefile? Maybe make it a Kconfig value?
# type = 0x13
PSP_SEC_DEBUG_FILE=$(top)/$(FIRMWARE_LOCATE)/secure_unlock_prod_RV.sbin
Optional?
To view, visit change 33764. To unsubscribe, or for help writing mail filters, visit settings.