[coreboot-gerrit] [S] Change in coreboot[main]: vendorcode/google/chromeos: API to read factory config

[Tim Van Patten (Code Review)]

Attention is currently required from: Subrata Banik.

Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79737?usp=email )

Change subject: vendorcode/google/chromeos: API to read factory config
......................................................................

Patch Set 1:

(2 comments)

File src/vendorcode/google/chromeos/ti50_misc_cmd.c:

https://review.coreboot.org/c/coreboot/+/79737/comment/a18917f9_70c44702 :
PS1, Line 20: 	if (rc == TPM_CB_NO_SUCH_COMMAND) {
`TPM_CB_NO_SUCH_COMMAND` is not the only value `tlcl_ti50_get_factory_config()` can return, so the other errors are being ignored and treated as "good" (`TPM_CB_MUST_REBOOT`, `TPM_IOERROR`).

This should instead be `if (rc != TPM_SUCCESS) {`, with a more generic log message that outputs the value of `rc`.

https://review.coreboot.org/c/coreboot/+/79737/comment/6de25076_58fd9e4f :
PS1, Line 26: 	return factory_config;
`factory_config` is a `uint64_t`, while this function returns a `uint8_t`.

These types need to match. The function should be updated to return `uint64_t`, so it matches what the GSC returns.