2 Sep
2023
2 Sep
'23
1:10 a.m.
Attention is currently required from: Elyes Haouas, Felix Held, Patrick Georgi.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76850?usp=email )
Change subject: [Please Test] payloads/libpayload/drivers/usb/ehci_private: Use C99 flexible arrays ......................................................................
Patch Set 3:
(1 comment)
File payloads/libpayload/drivers/usb/ehci_private.h:
PS1:
without having really looked into the details, it seems to me that this packed struct is used to acc […]
we could replace it with a union instead. Maybe like this: ``` u32 configflag; union { portsc_t portsc; u8 res2[0x40]; } __packed; u32 hostpc; ```
--
To view, visit https://review.coreboot.org/c/coreboot/+/76850?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec5bb3da8205326a43bba44630a8fcdcac651184
Gerrit-Change-Number: 76850
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Attention: Patrick Georgi patrick@coreboot.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 01 Sep 2023 23:10:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment