Attention is currently required from: Patrick Rudolph.

View Change

1 comment:

• File src/device/device_const.c:

  • Patch Set #1, Line 231: DEVTREE_CONST struct device *pcidev_path_on_segbus(unsigned int segment_group,

    Nico commented on this code when it was still part of CB:79927 :

    "TBH, I don't think this is a good idea. There are cases where looking up
    devices by bus numbers is unavoidable, e.g. external programs device/oprom/
    etc. But I wouldn't want to encourage usage by adding more APIs. (Also, the
    implementation below looks very questionable: starts with pci_root_bus()
    but still walks the global device list).

    The code is not wrong, though, so I'll leave this resolved."

To view, visit change 79980. To unsubscribe, or for help writing mail filters, visit settings.