Nico Huber merged this change.

View Change

Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved
nb/intel/x4x/rcven.c: Remove variable set but not used

Change-Id: I13d6593e283f0a9e6603e19ccfda116f3b145e52
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32948
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/northbridge/intel/x4x/rcven.c
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/northbridge/intel/x4x/rcven.c b/src/northbridge/intel/x4x/rcven.c
index 7c49838..36a6ebd 100644
--- a/src/northbridge/intel/x4x/rcven.c
+++ b/src/northbridge/intel/x4x/rcven.c
@@ -41,7 +41,6 @@

static u8 sampledqs(u32 addr, u8 lane, u8 channel)
{
- volatile u32 strobe;
u32 sample_offset = 0x400 * channel + 0x561 + lane * 4;

/* Reset the DQS probe */
@@ -50,7 +49,8 @@
MCHBAR8(RESET_CNTL(channel)) |= 0x2;
udelay(2);
barrier();
- strobe = read32((u32 *)addr);
+ /* Read strobe */
+ read32((u32 *)addr);
barrier();
return (MCHBAR8(sample_offset) >> 6) & 1;
}

To view, visit change 32948. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13d6593e283f0a9e6603e19ccfda116f3b145e52
Gerrit-Change-Number: 32948
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged