Patch Set 9:

(1 comment)

Patch Set 5:

Patch Set 5:

Use make savedefconfig to generate config files.

Would it work as good as this full .config? (no further questions should be asked about config during the beginning of make command)

P.S. Thank you very much for reviewing CB:31448 , will check it in more detail soon

yes. "cp defconfig .config; make olddefconfig" should work. Using full configfiles is not a good idea as coreboot is a moving target, with generally sane defaults which don't get set when you have a full config file.

I noticed one benefit of a full config: if you copy it to a freshly cloned coreboot, run "make menuconfig", exit with saving changes and then compare this config's original and modified versions: you could quickly notice the new useful config options recently added to coreboot (e.g. CONFIG_AGESA_EXTRA_TIMESTAMPS, although maybe it's not the best example). This isn't possible with these "shortened" configs

View Change

1 comment:

• File configs/config.lenovo_g505s_use_with_dgpu_patches:

  • Patch Set #6, Line 5: VGA_BIOS=y

    Adding blobs is never a coreboot default.

    But there are many boards which couldn't function without them. How their example configs are valid?

To view, visit change 32352. To unsubscribe, or for help writing mail filters, visit settings.