Patch Set 1:

do we also need to remove this param from the UPD display in soc/skylake/romstage/romstage.c ?

This is not necessary, since this option is used in the MEMORY_INIT_UPD structure only once:

https://github.com/coreboot/coreboot/blob/master/src/soc/intel/skylake/romstage/romstage.c#L231

If I understand correctly, this function displays the value of the fsp options specified in it.

https://github.com/coreboot/coreboot/blob/ef7a3267870f126cc2f815812cfe54500853d2b8/src/drivers/intel/fsp1_1/raminit.c#L310

This is not related to the soc_intel_skylake_config structure.

I think we should not change this, since we can see if the InternalGfx option in upd has been changed.

View Change

To view, visit change 32171. To unsubscribe, or for help writing mail filters, visit settings.