Attention is currently required from: Bill XIE.
29 comments:
File Documentation/mainboard/lenovo/s220.md:
Two empty lines
File Documentation/mainboard/lenovo/s220_ready_to_flash.jpg:
Please reduce the size of this image. I'd suggest cropping it to only show the area around the flash chip: https://imgur.com/Ehqn38w.png
File src/mainboard/hp/snb_ivb_laptops/cmos.default:
Patch Set #2, Line 5: volume=0x3
Seems unrelated?
File src/mainboard/lenovo/s220/Kconfig:
Schematics say Cougar Point (aka BD82X6X)
Patch Set #2, Line 43: default 8
No longer necessary
Patch Set #2, Line 51: default 0xff000000
Is this reserved anywhere?
File src/mainboard/lenovo/s220/acpi/ec.asl:
Nit: use consistent comment style?
Patch Set #2, Line 130: Store (One, PWRS)
Please use ASL 2.0 syntax:
PWRS = 1
Applies to all .asl files.
Remove this asterisk to match the comment style in the guidelines
File src/mainboard/lenovo/s220/acpi_tables.c:
Patch Set #2, Line 2: /* This file is part of the coreboot project. */
Please drop this comment
Patch Set #2, Line 5: #include <southbridge/intel/bd82x6x/nvs.h>
Needs an update
File src/mainboard/lenovo/s220/board_info.txt:
Patch Set #2, Line 4: FIXME
FIXME
File src/mainboard/lenovo/s220/devicetree.cb:
Patch Set #2, Line 6: register "gpu_dp_d_hotplug" = "4"
DP is not used?
Patch Set #2, Line 21: register "c3_battery" = "5"
Needs an update
Patch Set #2, Line 30: Host bridge Host bridge
One "Host bridge" is enough
nit: please align the `end` keywords
Patch Set #2, Line 36: register "gen1_dec" = "0x00000000"
Zero, please drop
File src/mainboard/lenovo/s220/dsdt.asl:
One blank line is enough
Missing #include <acpi/dsdt_top.asl>
File src/mainboard/lenovo/s220/early_init.c:
Patch Set #2, Line 2: /* This file is part of the coreboot project. */
Drop this comment
Patch Set #2, Line 4: FIXME
Should be easy to fix
Patch Set #2, Line 42: CONFIG_EC_BASE_ADDRESS | 1);
You have to reserve this memory range somewhere.
Patch Set #2, Line 50: FIXME
Hm?
File src/mainboard/lenovo/s220/ec.c:
Patch Set #2, Line 20: s230u
s220
File src/mainboard/lenovo/s220/gma-mainboard.ads:
Patch Set #2, Line 2: -- This file is part of the coreboot project.
Please drop
File src/mainboard/lenovo/s220/hda_verb.c:
Patch Set #2, Line 2: /* This file is part of the coreboot project. */
Drop
File src/mainboard/lenovo/s220/mainboard.c:
Patch Set #2, Line 63: lenovo_s230u_ec_init
hm?
File src/mainboard/lenovo/s220/smihandler.c:
Patch Set #2, Line 18: enum sleep_states {
src/include/acpi/acpi.h
Patch Set #2, Line 76: BIOS_INFO
_INFO? I'd say _DEBUG or _SPEW
To view, visit change 48771. To unsubscribe, or for help writing mail filters, visit settings.