I only had a brief look for now. Auto-generated static.h was something I commented as missing in CB:31933 patchset #5, this seems to add it, thanks.

Right. If that is generally useful, I'll split it out of this change.

For PCI devices, I was hoping we could have a template file under soc/ that defines such "static device node names" for all integrated devices (PCI bus 0, essentially). I think such approach would help us remove the defines in soc/pci_devs.h that eg. map XHCI0 to PCI 0:10.0.

Do I understand this right, an additional template file that is passed
to sconfig? And sconfig would then emit e.g. `xhci0_dev` instead of or
additionally to `__pci_0_14_0`?

I had a rather simple `pci_devs.h` in mind, that would just #define the
names, e.g.

    #include <static.h>
    #define pch_dev_xhci __pci_0_14_0

Not that I put much thought into it, just how I imagined it.

View Change

To view, visit change 35456. To unsubscribe, or for help writing mail filters, visit settings.