Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, Karthik Ramasubramanian. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58352 )
Change subject: soc/intel/alderlake: enable gpio locking ......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/alderlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/58352/comment/264cef26_a81c9597 PS1, Line 251: #if CONFIG(SOC_INTEL_COMMON_BLOCK_SMM_LOCK_GPIO_PADS)
I think you can make it work without any #ifs whatsoever and no weak functions either. […]
The way it works now, either the MB or the SoC can define the Kconfig without requiring the other one to be implemented. If we remove weak functions, we'll have to implement both SoC and MB at the same time. Or we say that SoC implementation must be first and they own the Kconfig and must implement a weak mb_gpio_lock_config() when they add their code that enables SOC_INTEL_COMMON_BLOCK_SMM_LOCK_GPIO_PADS. Preference?
Once we finish hashing this out and agree that the end-resulting code is the right approach, I'll implement this for TGL.
https://review.coreboot.org/c/coreboot/+/58352/comment/c4d6837e_8685283f PS1, Line 250: : #if CONFIG(SOC_INTEL_COMMON_BLOCK_SMM_LOCK_GPIO_PADS)
I don't think this is required
Done