Attention is currently required from: Nico Huber, Tim Wawrzynczak, Subrata Banik, Angel Pons, Michael Niewöhner, EricR Lai.

View Change

1 comment:

• File src/mainboard/intel/adlrvp/devicetree.cb:

  • Patch Set #62, Line 58:

    register "pch_pcie_rp[PCH_RP(8)]" = "{
    		.flags = PCIE_RP_CLK_SRC_UNUSED,
            }"
    	register "pcie_clk_config_flag[6]" = "PCIE_CLK_FREE_RUNNING"
    

    Since we now know that a free-running CLKSRC doesn't use any CLKREQ, how about expressing this as follows?

    I think the "free-running clock source" is basically useful for cases where it is not associated with any PCIe root port or used in some non-default configuration (e.g. PCIe multiplexers). In such cases, the clock source is marked as 0x80 instead of configuring it for a particular root port. Hence, I think it is important to allow the mainboard to configure the clock source without having to associate it with any root port. Same goes for CLK for LAN.

To view, visit change 48340. To unsubscribe, or for help writing mail filters, visit settings.