Patch Set 19:

Patch Set 19:

Coming back to this. I think we can agree that renaming of RELOCATABLE_RAMSTAGE(if really required) should probably be done as a separate commit and this change can focus primarily on clean up for the stage cache Kconfigs. Does that make sense?

https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/message/PCP6EI6UV6CFKVZCRO6SGDWIIWVGF5FQ/

In 24 April 2019 coreboot leadership minutes, you find mention that "Relocatable ramstage (on x86)" would be requirement for 4.11 release for platforms to stay on upstream master branch. I feel we just cause confusion if we rename the variable now, but no -2/+2 from me should such commit appear.

Equally my -2 here shall disappear if you can avoid the renaming.

I am totally fine with keeping "Relocatable ramstage" configs as is.

View Change

To view, visit change 33116. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45e894ad335a4661cc7916b3768e1614a038b31c
Gerrit-Change-Number: 33116
Gerrit-PatchSet: 19
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Huang Jin <huang.jin@intel.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 12 Jul 2019 05:20:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment