Attention is currently required from: Arthur Heymans, Marc Jones, Wonkyu Kim, Subrata Banik, Jonathan Zhang, Daocheng Bu, Rizwan Qureshi, Jingle Hsu, Sridhar Siricilla, Shuming Chu (Shuming), Shelly Chang.
View Change
1 comment:
Commit Message:
Patch Set #4, Line 15: get_me_fw_version
I didn't get you, get_me_fw_version() shouldn't be the last HECI command from coreboot to CSE in the […]
For our case we call get_me_fw_version after EOP and can see this issue. But I think this part of my commit message shouldn't be important and can be removed, since the Server ME spec requires clearing the interrupt.
To view, visit change 66579. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cf21112870e53a11134d43e461b735ead239717
Gerrit-Change-Number: 66579
Gerrit-PatchSet: 4
Gerrit-Owner: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans@9elements.com>
Gerrit-Reviewer: Daocheng Bu <daocheng.bu@intel.com>
Gerrit-Reviewer: Jingle Hsu <jingle_hsu@wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Reviewer: Shelly Chang <Shelly_Chang@wiwynn.com>
Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944@gmail.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla@intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland@gmail.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans@9elements.com>
Gerrit-Attention: Marc Jones <marc@marcjonesconsulting.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Attention: Daocheng Bu <daocheng.bu@intel.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Attention: Jingle Hsu <jingle_hsu@wiwynn.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla@intel.com>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944@gmail.com>
Gerrit-Attention: Shelly Chang <Shelly_Chang@wiwynn.com>
Gerrit-Comment-Date: Tue, 01 Nov 2022 11:24:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla@intel.com>
Gerrit-MessageType: comment