Werner Zeh merged this change.

View Change

Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved
x86emu: add console.h header to fix compilation

Commit 351e3e5 ("src: Use include <console/console.h> when appropriate")
has broken the build here, see below, so we include console.h here again.

In file included from src/device/oprom/x86emu/x86emui.h:65,
from src/device/oprom/x86emu/debug.c:40:
src/device/oprom/x86emu/debug.c: In function 'x86emu_dump_regs':
src/device/oprom/x86emu/debug.h:46:22: error: implicit declaration of function 'printk'; did you mean 'printf'?
[-Werror=implicit-function-declaration]
#define printf(x...) printk(BIOS_DEBUG, x)
^~~~~~
src/device/oprom/x86emu/debug.c:366:5: note: in expansion of macro 'printf'
printf("\tAX=%04x ", M.x86.R_AX );
^~~~~~

Fixes: 351e3e5 ("src: Use include <console/console.h> when appropriate")
Change-Id: I75d0b7c08bfa6dcb07778bbb762223b62cfc3da7
Signed-off-by: Martin Kepplinger <martink@posteo.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32499
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
---
M src/device/oprom/x86emu/debug.h
1 file changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/device/oprom/x86emu/debug.h b/src/device/oprom/x86emu/debug.h
index f89d5ab..01f633c 100644
--- a/src/device/oprom/x86emu/debug.h
+++ b/src/device/oprom/x86emu/debug.h
@@ -39,6 +39,8 @@
#ifndef __X86EMU_DEBUG_H
#define __X86EMU_DEBUG_H

+#include <console/console.h>
+
/*---------------------- Macros and type definitions ----------------------*/

/* printf is not available in coreboot... use printk */

To view, visit change 32499. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75d0b7c08bfa6dcb07778bbb762223b62cfc3da7
Gerrit-Change-Number: 32499
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Kepplinger <martink@posteo.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Martin Kepplinger <martink@posteo.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged