Arthur Heymans has uploaded this change for review.
drivers/intel/fsp1.1/car: Halt on improperly configured coreboot
Test if Kconfig symbols actually match what FSP does. If it is not
the case it best to halt right away instead of continuing to boot with
possibly hard to debug problems.
Change-Id: Ieec8259149cc8fd71c40fd1511a6a2cfa67c5337
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
---
M src/drivers/intel/fsp1_1/cache_as_ram.S
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/37281/1
diff --git a/src/drivers/intel/fsp1_1/cache_as_ram.S b/src/drivers/intel/fsp1_1/cache_as_ram.S
index fb39884..748c267 100644
--- a/src/drivers/intel/fsp1_1/cache_as_ram.S
+++ b/src/drivers/intel/fsp1_1/cache_as_ram.S
@@ -143,6 +143,11 @@
cmp $0, %eax
jne halt2
+ /* Check sanity of coreboot Kconfig symbols that need to match what FSP
+ does */
+ cmpl $(CONFIG_DCACHE_RAM_BASE + CONFIG_DCACHE_RAM_SIZE), %edx
+ jne .halt_forever
+
/* Setup BSP stack */
movl _ecar_stack, %esp
To view, visit change 37281. To unsubscribe, or for help writing mail filters, visit settings.