8 comments:
File src/mainboard/google/volteer/Kconfig:
This is a mainboard change. It should go in the next CL.
will move to mainboard cl...this one used to encompass both
File src/soc/intel/tigerlake/early_tcss.c:
Patch Set #24, Line 3: #include <bootstate.h>
Why is this required?
removed
Patch Set #24, Line 6: #include <ec/google/chromeec/ec.h>
Why is this required?
leftover from when this was calling ec commands removed
Patch Set #24, Line 102: while (--tries >= 0)
Just curious: Why are we trying 3 times? Is this operation known to fail for some reason?
This is for consistency with the depthcharge code, it can be removed. This loop should almost never be executed cause the only case it executes is if the response buffer is empty.
File src/soc/intel/tigerlake/fsp_params.c:
What does DSK mean?
Will clean this up...was using this for debug
Why WEAK?
Ack
Patch Set #24, Line 378: vboot_recovery_mode_enabled
What about developer mode? Wouldn't you need this in developer mode as well?
my understanding was this was mainly for user facing modes that had no OS I will add a developer mode check as well
File src/soc/intel/tigerlake/include/soc/early_tcss.h:
Patch Set #24, Line 130: mainboard_early_tcss_enable
What is the expectation from mainboard here? There should be a comment explaining the expectations.
adding comment in next patch
To view, visit change 42079. To unsubscribe, or for help writing mail filters, visit settings.