8 comments:
File src/soc/qualcomm/sc7180/clock.c:
Patch Set #15, Line 353: uint32_t mdss_clk_type)
It looks like this should fit into 96 characters.
Patch Set #15, Line 369: reg_addr = (void *)mdss_extclk_config[i].cbcr;
Is it common that this typo is not 0 or 1? Maybe add an else branch with a debug message?
Please use CB_SUCCESS and friends.
Patch Set #15, Line 410: CLK_CTL_RCG_MND_BMSK);
This should fit into 96 characters.
Please add enums for this.
File src/soc/qualcomm/sc7180/include/soc/addressmap.h:
Patch Set #15, Line 16: #define DISP_CC_BASE 0x0AF00000
Please align using tabs.
File src/soc/qualcomm/sc7180/include/soc/clock.h:
Patch Set #15, Line 34: #define mdss_reg_ptr(type, mem, base) \
Macros should be uppercase.
Patch Set #15, Line 35: ((offsetof(type, mem)) + base)
This fits into one line.
To view, visit change 39612. To unsubscribe, or for help writing mail filters, visit settings.