3 comments:
File src/soc/amd/picasso/include/soc/southbridge.h:
Patch Set #4, Line 225: #define FCH_LEGACY_UART_MAP_SHIFT 8
nit: If these are bitfield definitions, I'd indent them with 2 spaces as done in the rest of the file
File src/soc/amd/picasso/uart.c:
it's a warlking UART! 😄
const uint8_t range_idx[ARRAY_SIZE(uart_info)] = {
FCH_LEGACY_UART_RANGE_3F8,
FCH_LEGACY_UART_RANGE_2F8,
FCH_LEGACY_UART_RANGE_3E8,
FCH_LEGACY_UART_RANGE_2E8,
};
How about adding this information to uart_info instead?
To view, visit change 40322. To unsubscribe, or for help writing mail filters, visit settings.