> > If needed we may even create vpd_preram or vpd_romstage for that.

When I say this I was referring to vpd_preram.c or vpd_romstage.c, not functions.

a. create a vpd_romstage_gets() and vpd_romstage_find() call interface for romstage callers.

Probably no. I think your current version made it harder for people to figure out the right calling sequence.

We can have stage name in file level if needed, but better not in function name.
It's better to keep similar interfaces, but if needed we may still add extra param. I'd recommend

1. Change vpd_cbmem to vpd_cache
2. Change cbmem_add_cros_vpd to vpd_load_cache
3. inside vpd_load_cache, have a way to decide allocating from CBMEM, or a static variable (using malloc).

In this way we can get almost everything unchanged and keep the only minimal difference in single place.

View Change

To view, visit change 34634. To unsubscribe, or for help writing mail filters, visit settings.